Upgrade Actions versions and use non-deprecated release action #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwcd
reviewed
Jan 26, 2024
| with: | ||
| distribution: 'temurin' | ||
| java-version: 11 | ||
| - name: Build distribution | ||
| run: ./gradlew :adapter:distZip | ||
| - name: Create release | ||
| uses: actions/create-release@v1 | ||
| id: create_release | ||
| uses: softprops/action-gh-release@v1 |
There was a problem hiding this comment.
I would probably just use the gh CLI like we do for the language server, that way we don't have to pull in another third-party action: https://github.com/fwcd/kotlin-language-server/blob/eee8afa9b6b92c4c5ae445823b3719818d595ec1/.github/workflows/deploy.yml#L27-L45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building or releasing/deploying, we get errors from Github Actions. Most of these are deprecation warnings for Node12 , but some are usage of deprecated methods in our actions.
Also change the release action we are using. The old ones from Github are deprecated and no longer maintained. The new one is directly linked to from the repos of Githubs older actions. Hopefully it will behave 100 % the same.