-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Belarusian Cyrillic layout & add Łacinka #124
base: main
Are you sure you want to change the base?
Conversation
Sorry, I forgot to include Ў in the layout. But why remove И Ї Є? They are not top level keys, only long press options, and don't cause any problems. Even in the English keyboard you can get letters like Á even though they are not part of the English alphabet. |
"Less is better?" But yes, you're right. Compatibility across layouts is good... and following this thought, we also need to consider adding |
Ъ is automatically added in Cyrillic layouts under Ь, so we just need Щ under Ш |
Oh, ok. However, I would argue that placing |
Yes, it could be under both |
And about the Latin layout, making it long press based is bad for typing speed, it could be something like this:
This might be too big, but we don't have a proper layer system which could shrink the layout, so this is the best possible layout at the moment.
|
I never saw such a thing done before for Łacinka. It will definitely be confusing for the first timers |
That said, it's not a bad idea. Typing with an extra row really makes it faster when you get used to it. So, how about two layout options: with and without the fourth row? I think this is how it should look like:
|
Yes this is fine, and we can simplify the layout YAML:
|
Hi. Are there any further changes needed or is it ready to be merged? |
Hi. Can you review it once again? @abb128 |
Sorry for the delay, I'll try to get through the PR backlog this week |
Hi. Could you please make another review? |
Hi. Here is a brief overview of the changes introduced in this PR:
Let me know if there is anything I can do to make it easier for you. Before merging, I would appreciate discussing a few points. Is there a preferred way to contact you? Email, Discord, Zulip, or perhaps something else? Awaiting your reply |
The developer is busy, don't worry, it will be merged eventually. |
Hi. This PR fixes some errors with Belarusian Cyrillic layout and introduces an option for a Latin-based script, (Łacinka).
Changes in
Cyrillic/belarusian.yaml
:ў
: Added to the layout.щ
: Removed, as it does not exist in the Belarusian alphabet. Both Xorg and AOSP mapў
to this key.є
,и
, andї
: Removed, as these letters are specific to the Ukrainian alphabet and are not part of Belarusian.Also I renamed the file to
Cyrilic/belarusian_cyrillic.yaml
.Łacinka
LatinScript/belarusian_latin.yaml