Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix couple PHP notices #8

Open
wants to merge 15 commits into
base: gsit9.5
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ajax/deploypackage_form.php
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
$item = new $itemtype();
$item->move_item($params);
} else {
Toolbox::logDebug("package subtype not found : " . $params['itemtype']);
Toolbox::logDebug("package subtype not found : " . $itemtype);
Html::displayErrorAndDie ("package subtype not found");
}

Expand All @@ -86,14 +86,14 @@
exit;
}

if (!is_numeric($packages_id)) {
if (!is_numeric($packages_id) || intval($packages_id) <= 0) {
Toolbox::logDebug("Error: orders_id in request is not an integer");
Toolbox::logDebug(print_r($packages_id, true));
exit;
}

$pfDeployPackage = new PluginFusioninventoryDeployPackage();
$pfDeployPackage->getFromDB($packages_id);
$pfDeployPackage->getFromDB(intval($packages_id));

//TODO: In the displayForm function, $_REQUEST is somewhat too much for the '$datas' parameter
// I think we could use only $order -- Kevin 'kiniou' Roy
Expand All @@ -107,7 +107,7 @@
switch (filter_input(INPUT_POST, "subtype")) {
case 'package_json_debug':
if (isset($order->fields['json'])) {
$pfDeployPackage->displayJSONDebug();
echo $order->fields['json'];
} else {
echo "{}";
}
Expand Down
59 changes: 0 additions & 59 deletions ajax/deployuser.logged.in.php

This file was deleted.

2 changes: 1 addition & 1 deletion ajax/dropdownactionselection.php
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
header("Content-Type: text/html; charset=UTF-8");
Html::header_nocache();
}
if (!defined('GLPI_ROOT')) {
if (!defined('GLPI_ROOT') || !isset($CFG_GLPI)) {
die("Can not acces directly to this file");
}
Session::checkCentralAccess();
Expand Down
61 changes: 0 additions & 61 deletions ajax/dropdownactiontype.php

This file was deleted.

60 changes: 0 additions & 60 deletions ajax/dropdowndefinitionlist.php

This file was deleted.

80 changes: 0 additions & 80 deletions ajax/dropdowndefinitionselection.php

This file was deleted.

62 changes: 0 additions & 62 deletions ajax/dropdowndefinitiontype.php

This file was deleted.

Loading
Loading