Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/open logic fix #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rbrglez
Copy link

@rbrglez rbrglez commented Dec 26, 2024

This pull request solves issue #24

@obruendl
Copy link
Contributor

@olofk The implementation does seem to be inconsistent with the implementation. The documentation says paths are relative to .core files, the implementation interprets paths as relative to the repo. Please resolve the inconsistency - I am against accepting the pull request before the inconsistency is resolved - because the changes violate the documented behavior

See:

@obruendl
Copy link
Contributor

The behavior is understood - fusesoc documentation regarding file paths for .core files with provider keys shall be updated but this is related to fusesoc, not fusesoc-cores.

This PR is redundant (the same changes are applied through #21 )

@rbrglez Hence I suggest you close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants