add a11y notes for buttons - #27
Open
mo7orh3ad wants to merge 3 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
danbahrami
approved these changes
Mar 16, 2026
| #### No animation | ||
|
|
||
| <Alert intent="info" title="A11Y Requirement"> | ||
| - Do not use this variant if accessibility is a must have criterion and the component it's used in features multiple buttons in a row or column. |
Collaborator
There was a problem hiding this comment.
polish (non-blocking): Could we get a link or something that explains why this is important? I'm not sure why having multiple buttons in a row would change the requirements :)
Contributor
Author
There was a problem hiding this comment.
@danbahrami its basically the non text contrast criterion which states that:
This success criterion does not require that changes in color that differentiate between states of an
individual component meet the 3:1 contrast ratio when they do not appear next to each other.
As multiple buttons in a row or column would appear next to each other i'd strongly recommend to make sure we fulfil any eventualities.
Comment on lines
+22
to
+25
| <Alert intent="info" title="A11Y Requirement"> | ||
| - Do not use tertiary buttons as replacements for text links in inline text as they might not provide enough contrast to surrouding text. | ||
| - These buttons are not intended to be used as tab or accordion controls or any other control requiring an active state. | ||
| </Alert> |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.