Skip to content

add a11y notes for buttons - #27

Open
mo7orh3ad wants to merge 3 commits into
mainfrom
feat/a11y-docs
Open

add a11y notes for buttons#27
mo7orh3ad wants to merge 3 commits into
mainfrom
feat/a11y-docs

Conversation

@mo7orh3ad

Copy link
Copy Markdown
Contributor

No description provided.

@mo7orh3ad
mo7orh3ad requested a review from danbahrami March 13, 2026 16:30
@vercel

vercel Bot commented Mar 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
taylorui Ready Ready Preview, Comment Mar 18, 2026 9:16am

Comment thread src/app/components/button/page.mdx Outdated
#### No animation

<Alert intent="info" title="A11Y Requirement">
- Do not use this variant if accessibility is a must have criterion and the component it's used in features multiple buttons in a row or column.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

polish (non-blocking): Could we get a link or something that explains why this is important? I'm not sure why having multiple buttons in a row would change the requirements :)

@mo7orh3ad mo7orh3ad Mar 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danbahrami its basically the non text contrast criterion which states that:

This success criterion does not require that changes in color that differentiate between states of an
individual component meet the 3:1 contrast ratio when they do not appear next to each other.

As multiple buttons in a row or column would appear next to each other i'd strongly recommend to make sure we fulfil any eventualities.

Comment thread src/app/components/button/page.mdx Outdated
Comment on lines +22 to +25
<Alert intent="info" title="A11Y Requirement">
- Do not use tertiary buttons as replacements for text links in inline text as they might not provide enough contrast to surrouding text.
- These buttons are not intended to be used as tab or accordion controls or any other control requiring an active state.
</Alert>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought (non-blocking): It feels a bit too strong to come right in with this at the top before we even see any examples.

Image

Wondering if we could move this down a little bit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants