-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Replace deprecated zero_copy_only
argument with allow_copy
#222
base: main
Are you sure you want to change the base?
chore: Replace deprecated zero_copy_only
argument with allow_copy
#222
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Ciao @khrapovs, thank you for this PR! 😊 I noticed GH says there are conflicts with the main branch: would you mind reviewing them? Also, I could not keep up with Polars versioning and API changes, so for the moment we are stuck with essentially |
…-zero_copy_only # Conflicts: # functime/feature_extractors.py
Apologies, clicked the wrong button. The branch is now up-to-date.
In my own project |
Thanks!
Uh that's what I was suspecting. Unfortunately, we can't just merge this immediately (and have some parts of the codebase supporting Polars>=0.20.31 and some other >=0.20.7). I'm working on conformal predictions right now but of course supporting the latest Polars is my goal. I'll keep this PR when we are working on this (pretty substantial) effort (which is going to happen very soon). Issue is #159. Anyone is free to add a checklist of stuff to do! |
This problem can be solved by something along these lines:
But would anyone tolerate this ugliness in the codebase? Even if it is temporary until the lower requirement for polars is risen until X? |
What does this implement/fix? Explain your changes.
Replace deprecated
zero_copy_only
argument withallow_copy
(https://docs.pola.rs/py-polars/html/reference/series/api/polars.Series.to_numpy.html). For example, I get this warning: