Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plotting): add sampling param #158

Merged
merged 1 commit into from
Feb 22, 2024
Merged

feat(plotting): add sampling param #158

merged 1 commit into from
Feb 22, 2024

Conversation

baggiponte
Copy link
Collaborator

@baggiponte baggiponte commented Jan 5, 2024

I've been meaning to do this for a while now. Plotting functions now have a num_series param (and seed) to sample some series (by default, 10). In this way, users don't have to do the filtering themselves.

Don't know if this implementation is optimal. We are still collecting all entities.

I also would like to implement a "rank_by" to plot images in order. Adding another parameter is the fastest way but I am not in love with it: too much complexity.

I am leaving this here, as food for thought: I am tempted by the OOP approach:

y = functime.PanelDataFrame.from_polars(...) # basically a LazyFrame with some type checks and stores the "state" AKA entity, time and value cols

y.rank(by=..., how="best").plot(n_series=10)

@baggiponte baggiponte added enhancement New feature or request plotting Plotting features labels Jan 5, 2024
@baggiponte baggiponte added this to the 0.10 milestone Jan 5, 2024
@baggiponte baggiponte self-assigned this Jan 5, 2024
Copy link

vercel bot commented Jan 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
functime-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 10:51pm

Copy link
Contributor

@topher-lo topher-lo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@topher-lo topher-lo merged commit 2d63ad3 into functime-org:main Feb 22, 2024
@baggiponte baggiponte deleted the feat2023/plot-samples branch February 22, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plotting Plotting features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants