feat(plotting): add sampling param #158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been meaning to do this for a while now. Plotting functions now have a
num_series
param (andseed
) to sample some series (by default, 10). In this way, users don't have to do the filtering themselves.Don't know if this implementation is optimal. We are still collecting all entities.
I also would like to implement a "rank_by" to plot images in order. Adding another parameter is the fastest way but I am not in love with it: too much complexity.
I am leaving this here, as food for thought: I am tempted by the OOP approach: