Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Move all feature extractors into namespace only + speedup Lempel Ziv #113

Merged
merged 11 commits into from
Nov 7, 2023

Conversation

abstractqqq
Copy link
Collaborator

Improved performance for Lempel Ziv by applying the change to Hashbrown suggested by Ritchie

BREAKING CHANGE:

  1. The functime.feature_extraction.tsfresh module is merged into functime.feature_extractor. This has 2 advantages: (a). Simpler, keeping things in one place and shorter import path. (b) This avoids a potential circular import. If we write plugin code, the code needs to be registered in a namespace (in feature_extractor.py), but for Series to benefit from it, we have to import the code to tsfresh.py. But feature_extractor module imports from tsfresh.py... Hence the circular import. Merging them together solves this issue

Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
functime-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 9:07am

@abstractqqq
Copy link
Collaborator Author

@topher-lo Any idea why Vercel is failing?

@topher-lo
Copy link
Contributor

Screenshot 2023-11-06 023920

@topher-lo topher-lo added enhancement New feature or request priority: high labels Nov 6, 2023
@topher-lo topher-lo added the perf Performance or optimization improvements label Nov 7, 2023
@topher-lo topher-lo changed the title Restructure and Improved Perf for Lempel Ziv feat!: Move all feature extractors into namespace only + speedup Lempel Ziv Nov 7, 2023
@topher-lo topher-lo merged commit 77eca8a into main Nov 7, 2023
5 checks passed
@topher-lo topher-lo deleted the fix/improv_lempel_ziv branch November 7, 2023 09:08
topher-lo pushed a commit that referenced this pull request Nov 7, 2023
topher-lo pushed a commit that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request perf Performance or optimization improvements priority: high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants