fix(notifications): stop logging recipient email (CodeQL #27)#1314
Merged
Conversation
Resolves CodeQL cs/exposure-of-sensitive-information (alert #27). The delivery-failure warning logged the raw recipient address, writing PII to an external sink (the log). Drop {Email} from the template; {Context} already identifies the operation for debugging. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Resolves CodeQL cs/exposure-of-sensitive-information (alert #27, CWE-359, medium).
BillingEmailSender.SendAsynclogged the raw recipient address on a delivery failure ("Failed to send {Context} email to {Email}"), writing PII to an external sink (the log). The{Email}placeholder is dropped;{Context}already identifies the operation for debugging.Why this is safe
The email is still used to actually send the message — only the log statement changed. No behavior change beyond log content.
🤖 Generated with Claude Code