chore(nuget): publish-readiness fixes for CLI + template packages#1303
Merged
Conversation
Validated the full publish pipeline end-to-end (pack -> install -> scaffold full/no-aspire/no-frontend -> build backend+frontends -> run Aspire stack -> auth + endpoints). Three fixes surfaced: - pack: stop shipping a local AI-tool settings file. src/.claude/settings.local.json was tracked and leaked into both the template package and scaffolded output (root .gitignore only anchored /.claude/). Untrack it and ignore **/.claude/ settings.local.json at any depth. - template pkg: render a README on the nuget.org gallery page. The template pack lives outside src/ so it never inherited src/Directory.Build.props's PackageReadmeFile; add PackageReadmeFile + the root README at package root (same README the CLI ships). Clears the "missing a readme" pack warning. - aspire: pin the dashboard to the documented port 15888. launchSettings used an auto-generated 17273 while the README, README-template, fsh CLI "Next Steps" (FshConstants.AspireDashboardPort) and `fsh doctor` all advertise 15888. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-publish validation of the
FullStackHero.CLIandFullStackHero.NET.StarterKitpackages. Ran the full pipeline end-to-end and fixed three issues found along the way.Validation performed
node_modules/bin/obj/.terraform/.tfstate/.claude).fshCLI install; scaffolded full, --no-aspire, and --no-frontend variants. Renames correct (Acme.Store.AppHost,Projects.Acme_Store_Api, OpenAPI title "Acme Store API"), conditional excludes correct.npm install+ production build clean./health/live+/health/ready200; Scalar 200; both frontends serve 200; root-admin JWT issued andGET /api/v1/tenantsreturned seeded data.Fixes
src/.claude/settings.local.jsonwas tracked and leaked into both the template package and scaffolded output (root.gitignoreonly anchored/.claude/). Untracked + ignore**/.claude/settings.local.jsonat any depth.src/so it never inheritedsrc/Directory.Build.props'sPackageReadmeFile; addedPackageReadmeFile+ root README so the nuget.org gallery page renders (clears the "missing a readme" pack warning). The logo (icon.png) is already embedded at the root of both packages.launchSettings.jsonused an auto-generated17273while the README, README-template,fshCLI "Next Steps" (FshConstants.AspireDashboardPort), andfsh doctorall advertise15888. Pinned to15888so docs/CLI/doctor match reality.🤖 Generated with Claude Code