fix(deps): pin transitive MessagePack to 2.5.301 (NU1903 breaks all CI)#1299
Merged
Conversation
GitHub advisory GHSA-hv8m-jj95-wg3x (high severity, LZ4 decompression AccessViolationException) was published against MessagePack < 2.5.301, which Microsoft.AspNetCore.SignalR.StackExchangeRedis pulls in at 2.5.187. NuGet audit runs with warnings-as-errors, so every restore in CI now fails with NU1903 — breaking all PR checks regardless of their content. CentralPackageTransitivePinningEnabled is on, so a single PackageVersion entry bumps the transitive across the solution. Remove the pin once the SignalR backplane package references a patched MessagePack itself. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
GitHub advisory GHSA-hv8m-jj95-wg3x (high severity — LZ4 decompression
AccessViolationException) was published against MessagePack < 2.5.301.Microsoft.AspNetCore.SignalR.StackExchangeRedis10.0.8 pulls MessagePack 2.5.187 transitively, and NuGet audit runs with warnings-as-errors — so everydotnet restorein CI now fails with NU1903, breaking all PR checks repo-wide (this is what turned #1298 and every other open PR red).What
One
PackageVersionentry inDirectory.Packages.propsunder a new "Transitive security pins" group.CentralPackageTransitivePinningEnabledis already on, so this single entry bumps the transitive across the whole solution (and thedotnet new fshtemplate, which packs from this same source).Remove the pin once the SignalR backplane package depends on a patched MessagePack itself.
Testing
dotnet restore --force-evaluate— exit 0, no NU1903/NU1109.dotnet build src/FSH.Starter.slnx— 0 warnings, 0 errors (warnings-as-errors).🤖 Generated with Claude Code