docs(adr): ADR 0064 — deprecate customized/ directory overlay#2811
Conversation
PR Summary by QodoAdd ADR 0064 to deprecate customized/ directory overlay
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Site previewPreview: https://36b7df13-site.fullsend-ai.workers.dev Commit: |
|
🤖 Review · |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Code Review by Qodo
1. docs/architecture.md not updated
|
217214a to
fc11950
Compare
|
🤖 Finished Review · ✅ Success · Started 1:24 AM UTC · Completed 1:37 AM UTC |
ReviewFindingsMedium
Previous runReviewFindingsHigh
Medium
Previous runReviewFindingsMedium
Labels: Docs-only PR adding an ADR and implementation plan for deprecating the harness customization overlay. Previous runReviewFindingsHigh
Medium
Previous run (2)ReviewFindingsMedium
Labels: Docs-only PR adding an ADR and implementation plan for deprecating the harness customization overlay. |
fc11950 to
4d0431c
Compare
|
/fs-review |
4d0431c to
baf2b89
Compare
|
🤖 Finished Review · ✅ Success · Started 11:24 AM UTC · Completed 11:38 AM UTC |
waynesun09
left a comment
There was a problem hiding this comment.
Review Squad + ADR Review — 5 agents (Claude ×3, Gemini, Codex)
ADR 0064: LGTM
The ADR is well-structured, concise (78 lines, under 80 target), and technically accurate. All convention checks pass. The replacement mapping table is verified against the actual codebase — base: composition (compose.go), URL resources (resolve.go), and agent registration (config/agents.go) are all shipped and working. Prerequisites are met.
Implementation Plan: 8 findings (MEDIUM)
The plan is solid overall but has coverage gaps — it misses 5 files with real customized/ references and lists 3 files that don't need changes. These should be fixed before implementation begins.
1. MEDIUM — Plan misses repo-maintenance.yml overlay (consensus: 3/5 agents)
internal/scaffold/fullsend-repo/.github/workflows/repo-maintenance.yml (lines 57-63) has its own customized/scripts overlay using hardcoded paths, NOT the CUSTOM_BASE variable. The PR 5 grep for CUSTOM_BASE won't catch it. Additionally, scaffold_test.go:735 asserts this overlay exists.
→ Add to PR 2 or PR 3 scope.
2. MEDIUM — Plan misses e2e/admin/admin_test.go (consensus: 2/5 agents)
Lines 173-180 assert all 8 customized/*.gitkeep files exist after install. Removing scaffold code without updating this e2e test will break CI.
→ Add to PR 3 test updates.
3. MEDIUM — Bash syntax error in removal snippet (consensus: 3/5 agents)
PR 2's code block has ]; do instead of ]; then (invalid bash). The actual workflows use ]; then.
→ Fix the snippet.
4. MEDIUM — Plan misses internal/layers/workflows_test.go (consensus: 2/5 agents)
Line 455 asserts modes["customized/agents/.gitkeep"] has mode "100644".
→ Add to PR 3 test scope.
5. MEDIUM — Plan misses .pre-commit-tools.yaml scaffold comments (consensus: 3/5 agents)
internal/scaffold/fullsend-repo/scripts/.pre-commit-tools.yaml (lines 37-39) documents customized/scripts/ as L1 override.
→ Add to PR 3 or PR 4.
6. MEDIUM — Plan misses docs/plans/deprecate-per-org-install.md (1 agent)
Lines 212-216 describe copying from customized/ directories.
→ Add to PR 4 with supersession annotation.
7. MEDIUM — ADRs 0036/0055 listed in PR 4 but have no customized/ path references (1 agent)
These use "customized" only as an English word. Including them would be unnecessary churn.
→ Remove from PR 4's ADR cross-reference list.
8. MEDIUM — docs/agents/README.md listed in PR 4 but has no customized/ references (1 agent)
grep 'customized/' docs/agents/README.md returns zero matches.
→ Remove from PR 4 file list.
baf2b89 to
9aeda6d
Compare
|
🤖 Review · |
9aeda6d to
d87c93a
Compare
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 12:05 AM UTC · Completed 12:19 AM UTC |
Signed-off-by: Greg Allen <gallen@redhat.com> Signed-off-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Greg Allen <gallen@redhat.com>
d87c93a to
2fae223
Compare
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 12:26 AM UTC · Completed 12:36 AM UTC |
|
Review skipped — this PR is already merged. The Posted by fullsend pre-review check |
|
🤖 Finished Retro · ✅ Success · Started 12:29 AM UTC · Completed 12:40 AM UTC |
|
Review skipped — this PR is already merged. The Posted by fullsend post-review check |
Retro: PR #2811 — ADR 0064 (deprecate customized/ directory overlay)A 4-file docs-only PR (ADR + implementation plan) by a human author. The review pipeline found a genuinely valuable high-severity finding (scripts/env gap in the deprecation scope) that the human fixed. The multi-agent Review Squad also found 8 MEDIUM findings on the implementation plan, most of which were actionable. What went well:
Patterns observed (covered by existing issues):
One novel pattern identified: Multiple review runs posted independent status comments ("Finished Review, Success", "Review cancelled", then detailed findings from yet another run), creating a confusing timeline. The human triggered Proposals filed
|
Summary
customized/directory overlay mechanism (ADR 0035)base:harness composition (ADR 0045), URL-based resource references (ADR 0038), and config-based agent registration (ADR 0058)docs/plans/deprecate-customized-directory-overlay.mdcovering deprecation warnings, workflow cleanup, scaffold removal, docs updates, and final grep sweepTest plan
grep -r customizedoutput🤖 Generated with Claude Code