fix: align H1 headings with frontmatter title convention#36
Conversation
The experiment numbering convention (PR #35) set frontmatter titles to the `NNNN. Title` format but left H1 headings with their old inconsistent formats (e.g. "Experiment 002:", "PoC FullSend", "ADR 0022"). This causes the fullsend docs site sidebar to display wrong titles since it falls back to H1 when rendering directory entries. Update all 21 experiment H1 headings to match their frontmatter title field exactly. Assisted-by: Claude (fix) Signed-off-by: Wayne Sun <gsun@redhat.com>
|
🤖 Review · |
PR Summary by QodoAlign experiment H1 headings with frontmatter titles
AI Description
Diagram
High-Level Assessment
Files changed (21)
|
Rename review-cache-experiment to 0023-review-cache, add required frontmatter (title, status, topics), update H1 heading, and add entry to README index table. Assisted-by: Claude (fix) Signed-off-by: Wayne Sun <gsun@redhat.com>
|
🤖 Review · |
Code Review by Qodo
1.
|
| --- | ||
|
|
||
| # Experiment 002: Claude-based ADR Drift Scanner | ||
| # 2. Claude-based ADR drift scanner |
There was a problem hiding this comment.
2. Stale experiment link labels 🐞 Bug ⚙ Maintainability
Several docs still refer to experiments using the old label format (e.g., “Experiment 002”) even though the experiment pages are now titled as “2. …”. This leaves cross-references that no longer match the destination page titles/H1s.
Agent Prompt
## Issue description
After renaming experiment entry H1s/titles to the `N. Title` convention, multiple in-repo references still use the legacy `Experiment 00N` wording. This makes cross-references inconsistent with the new canonical experiment titles.
## Issue Context
Examples include relationship sections and comparison headings that still say “Experiment 002”, “Experiment 003”, etc., while the target pages now start with “2.”, “3.”, etc.
## Fix Focus Areas
- 0001-agent-outage-fire-drill.md[100-103]
- 0003-scanner/README.md[23-29]
- 0004-meta-loop-self-improving-engine/README.md[140-155]
- 0011-integration-service-design-drift/README.md[257-264]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Add validation to lint-experiment-frontmatter that enforces H1 heading matches the frontmatter title field exactly. Prevents future drift between the two after the convention was established. Also fixes 0006-code-agent-evaluation which had a pre-existing mismatch caught by the new check. Assisted-by: Claude (fix) Signed-off-by: Wayne Sun <gsun@redhat.com>
|
🤖 Review · |
Align with repo convention — all experiments use README.md as the primary document. Update cross-references in RECOMMENDATION.md (4) and invoke-variant.sh (1). Assisted-by: Claude Signed-off-by: Wayne Sun <gsun@redhat.com>
|
🤖 Finished Review · ❌ Failure · Started 9:04 PM UTC · Completed 9:14 PM UTC |
ReviewVerdict: approve · 1 low finding Clean consistency fix that aligns H1 headings with frontmatter titles across 21 experiments, standardizes the
The prior low-severity finding about the dead Findings1. No linked issue for non-trivial changeSeverity: low · Category: missing-authorization · File: N/A This PR touches 43 files and adds linter validation but has no linked issue. The work clearly follows from merged PR #35 (experiment numbering conventions) and is architecturally sound, fitting the conventions documented in AGENTS.md. The scope is well-defined and internally consistent. Dimensions reviewed: correctness, security, intent & coherence, style/conventions, documentation currency. Cross-repo contracts skipped (no exported interfaces modified). No security findings.
Labels: PR updates documentation headings and adds documentation linting enforcement. Previous runReviewVerdict: comment · 3 medium, 2 low findings Clean consistency fix that aligns H1 headings with frontmatter titles across 21 experiments, standardizes the Findings1.
|
Trailing whitespace, ruff lint fixes (13 errors), and ruff format on review-cache experiment files. Assisted-by: Claude Signed-off-by: Wayne Sun <gsun@redhat.com>
|
🤖 Review · |
- extract_h1() now skips YAML frontmatter to avoid matching comments - Fix stale EXPERIMENT.md self-reference in 0006 file tree - Fix stale review-cache-experiment/ directory name in 0023 file tree - Remove dead EXPERIMENT.md fallback from both lint scripts Assisted-by: Claude Signed-off-by: Wayne Sun <gsun@redhat.com>
|
🤖 Finished Review · ✅ Success · Started 9:20 PM UTC · Completed 9:28 PM UTC |
|
🤖 Finished Retro · ✅ Success · Started 10:20 PM UTC · Completed 10:26 PM UTC |
|
PR #36 aligned H1 headings with frontmatter titles across 21 experiments, renamed a non-conforming experiment directory, and added a lint check to enforce H1/title consistency. The fullsend-ai review agent performed well, catching 3 medium-severity bugs (frontmatter-skipping in Proposals filed
|
Summary
title:fieldNNNN. Titleformat but left H1 headings with old inconsistent formats (Experiment 002:,PoC FullSend,ADR 0022, etc.)Test plan
for d in 0*/; do fm=$(grep -m1 "^title:" "$d/README.md" | sed 's/^title:\s*//' | tr -d '"'); h1=$(grep -m1 "^# " "$d/README.md" | sed 's/^# //'); [ "$fm" != "$h1" ] && echo "MISMATCH: $d"; donelint-experiment-numbers,lint-experiment-frontmatter,lint-experiment-index)