fix(#83): use correct variable in new issues confidence gate#84
Conversation
In the new-issues loop of post-scribe.sh, line 376 used
${TOPIC} (set only in the existing-issues loop) instead
of ${TITLE} (the loop-local variable). In new_issues_only
mode, TOPIC is never assigned, causing an unbound variable
crash under set -euo pipefail when a new issue has an
invalid confidence value.
Change gate_reject call on line 376 from ${TOPIC} to
${TITLE}, matching the correct usage on line 380 in the
same loop. Add a test case that exercises new_issues_only
mode with a non-numeric confidence value, which crashed
before this fix and now produces a clean gate rejection.
Note: pre-commit could not run shellcheck hook (sandbox
network restriction). The low-confidence-rejected test
has a pre-existing failure due to missing bc in sandbox.
Closes #83
Functional tests did not runFunctional tests run automatically for org/repo members and collaborators on pull requests. For other contributors, a maintainer must add the |
|
🤖 Finished Retro · ✅ Success · Started 6:36 PM UTC · Completed 6:43 PM UTC |
|
PR #84 fixed a copy-paste variable bug in post-scribe.sh ( Proposals filed
|
In the new-issues loop of post-scribe.sh, line 376 used ${TOPIC} (set only in the existing-issues loop) instead of ${TITLE} (the loop-local variable). In new_issues_only mode, TOPIC is never assigned, causing an unbound variable crash under set -euo pipefail when a new issue has an invalid confidence value.
Change gate_reject call on line 376 from ${TOPIC} to ${TITLE}, matching the correct usage on line 380 in the same loop. Add a test case that exercises new_issues_only mode with a non-numeric confidence value, which crashed before this fix and now produces a clean gate rejection.
Note: pre-commit could not run shellcheck hook (sandbox network restriction). The low-confidence-rejected test has a pre-existing failure due to missing bc in sandbox.
Closes #83
Post-script verification
agent/83-fix-scribe-confidence-gate)e017eaa080f40ab8cc347b589b92c0847d571b28..HEAD)