-
Notifications
You must be signed in to change notification settings - Fork 2
WIP Backlog/framework loader #540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
result = {} | ||
entities = options.get('selection', []) | ||
if not entities: | ||
raise PluginExecutionError('No entities selected!') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider removing the exlamation mark (!) and just use a dot: "No entities selected."
Git gives a bit more of a formal tone in the error messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sorry I didn't saw it when reviewing the code. Changed now.
…ations into backlog/framework-loader
WIP do not merge
Resolves :
This PR has been tested on :
Overview
Purpose: Ftrack framework loader to be able to load components directly from the ftrack interface to the DCC.
Scope:
Implementation Details
Approach: Based on having one single session and one single event manager that allows users to decide wether they want to run a specifc event in remote or in local mode. That provide us the ability for the client to subscribe to ftrack default remote events like action_discover and action_launch.
subscribe_action_tool
) to subscribe to the action events for a specific toolReasoning:
Changes:
Trade-offs:
Testing
Tests Added:
Manual Testing: Its very hard to manually test this PR alone. I have created the following branch to test it on maya with all the needed dependencies.
experimental/test-loader
Don't worry about testing this, we need to first decide if the implementation is the way we want it to be. Then we will test this in the DCC specifc PRs.
Testing Environment:
Notes for Reviewers
Focus Areas:
Dependencies: Highly dependant on:
Known Issues: