chore!: Remove public abortController option #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmycallin
changed the title
jimmycallin
changed the title
gismya
reviewed
Jul 24, 2025
source/session.ts
Outdated
| @@ -553,7 +553,6 @@ export class Session< | |||
| * @typeParam T - Either an array of response types to get return type `Tuple<T[0], ..., T[n]>`, or a single response type to get return type T[]. Default is ActionResponse. | |||
| * @param {Array} operations - API operations. | |||
| * @param {Object} options | |||
| * @param {AbortController} options.abortController - Abort controller, deprecated in favor of options.signal | |||
| * @param {AbortSignal} options.signal - Abort signal | |||
| * @param {string} options.pushToken - push token to associate with the request | |||
| * @param {object} options.headers - Additional headers to send with the request | |||
There was a problem hiding this comment.
Not directly relevant to this PR, but options.headers should be
Suggested change
| * @param {object} options.headers - Additional headers to send with the request | |
| * @param {object} options.additionalHeaders - Additional headers to send with the request |
and ensureSerializableResponse is missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #114
Changes
Test