Skip to content

chore!: Specify supported node versions #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore!: Specify supported node versions #308

wants to merge 1 commit into from
+3 −0

Conversation

jimmycallin
Copy link
Contributor

Resolves #104

  • I have added automatic tests where applicable
  • The PR title is suitable as a release note
  • The PR contains a description of what has been changed
  • The description contains manual test instructions

Changes

Test

@jimmycallin jimmycallin requested a review from a team as a code owner July 23, 2025 21:50
@jimmycallin jimmycallin changed the title chore: Specify supported node versions chore!: Specify supported node versions Jul 23, 2025
@gismya
Copy link
Contributor

gismya commented Jul 24, 2025

Should the .nvmrc reflect the lowest accepted node version or be kept as is and be the "recommended" version?

@jimmycallin
Copy link
Contributor Author

Should the .nvmrc reflect the lowest accepted node version or be kept as is and be the "recommended" version?

I think we can keep it as being the current LTS version, as it's mainly used for development, and CI. Ideally we would run CI for each supported node version, but feels bit overkill tbh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove support for Node v14 - v18
2 participants
@jimmycallin @gismya