Skip to content

Set cachable to false #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Set cachable to false #60

wants to merge 2 commits into from

Conversation

benrutter
Copy link
Contributor

Closes issue #42

At the moment, because SSHFS is considered cachable, creating a new filesystem doesn't create a new connection, and maintains the old one.

That's probably not a good fit for SFTP connections, since they're likely to timeout and be closed off after a while, so almost any long running process using SSHFS is eventually going to hit an issue where the filesystem continues to reference a closed off connection, and the cache needs to be manually cleared.

To fix that, I've just set "cachable" to False here, so that creating a new filesystem would also bring in a new connection.

Honestly, I don't have the knowledge to know the full implications of this, but my main thoughts are:

  • Does this mean it's worth adding in something to clean up / close the connection when the SSHFS object goes out of memory? (otherwise there are potentially open but unusable connections floating around)
  • Is there a case where you'd want it to be cachable? In which case, the "cachable" setting could theoretically be put behind an __init__ argument? (my guess is that'd cause some kind of side effects nobody is expecting though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant