Guess file content type when not specified #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the default mime type behavior for this library by guessing the correct mime type when one is not provided. This improves the accuracy of the default behavior in representing the files and matches other fsspec implementations. Closes fsspec#654
kujenga
force-pushed
the
at/mime-type-guess
branch
from
1816f21 to
df58ae8
Compare
kujenga
changed the title
|
I must admit to not being particularly fond of this kind of guessing, but since the user can always override, I suppose it's OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the default content type behavior for this library by guessing the correct mime type when one is not provided. This improves the accuracy of the default behavior in representing the files and matches other fsspec implementations.
Closes #654