Accept and propagate api_version argument through factory functions - #555
Open
amotl wants to merge 1 commit into
Open
Accept and propagate api_version argument through factory functions#555amotl wants to merge 1 commit into
api_version argument through factory functions#555amotl wants to merge 1 commit into
Conversation
amotl
changed the title
api_version argument in factory functions
amotl
changed the title
api_version argument in factory functionsapi_version argument through factory functions
The Azurite service emulator does not always implement the newest API versions of the original Azure Blob and Data Lake Storage APIs running in production. As of today, it is needed to define `api_version=2025-11-05` to connect successfully.
Collaborator
|
Hi @amotl! Before doing a deeper review, we just want to make sure that this change is necessary. Is there a reason you're unable to use the |
Author
|
Ah, that flag is on the Azurite container, right. I will try, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. Thanks a stack for conceiving adlfs. When aiming to run integration tests (panodata/omniload#249), we ran into a problem.
Problem
The Azurite service emulator does not always implement the newest API versions of the original Azure Blob and Data Lake Storage APIs running in production.
Solution
As of today, it is needed to define
api_version=2025-11-05to connect successfully to Azurite. This patch allows users to define the API version when using adlfs.