Pass --multiemit- as default option for FsiEvaluator.
#816
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be good to understand what the problem is. Any specifics? It's ok to turn off multiemit (it's primarily for debug symbols) but I'd like to understand better what's failing. |
|
@dsyme it first surfaced during the upgrade to FCS 43. Some |
|
We should definitely investigate this behaviour, but I'm going to merge this in for the time being as it does break certain use cases. |
|
This didn’t bump the release. The nuget version is still 18.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating to v18 in Fantomas, we noticed that Linux is no longer processing
(*** include-output ***).When locally (in WSL) adding
--multiemit-toFsiEvaluatoris started working again.I propose we ship this out of the box.
Thoughts @baronfel?