Skip to content
This repository was archived by the owner on Mar 12, 2024. It is now read-only.

Match build.fsx to Makefile #7 #8

Merged
merged 9 commits into from
May 26, 2015

Conversation

panesofglass
Copy link
Contributor

No description provided.

@forki
Copy link
Member

forki commented May 23, 2015

If you keep using nuget then you should keep the restorepackages phase in the build script

@panesofglass
Copy link
Contributor Author

NuGet is only needed to fetch FAKE from install.cmd.

@forki
Copy link
Member

forki commented May 23, 2015

Then it should be easy to switch to paket bootstrapper ;-)
On May 23, 2015 09:15, "Ryan Riley" [email protected] wrote:

NuGet is only needed to fetch FAKE from install.cmd.


Reply to this email directly or view it on GitHub
#8 (comment).

@rneatherway
Copy link
Member

I would definitely switch to Paket. The nuget usage and path ../lib/nuget/nuget.exe is from when this was a subdirectory in the fsharpbinding repository. I think there is no need to stick with nuget now.

@panesofglass
Copy link
Contributor Author

I'll add that later today!

@panesofglass
Copy link
Contributor Author

I actually thought about switching to powershell, as that would not require us to download any other tools. Thoughts?

@panesofglass
Copy link
Contributor Author

Hmm, though I suppose FAKE + Paket would be sufficient for a single "build" script.

@rneatherway
Copy link
Member

If you are thinking of removing the Makefile and just using Paket/FAKE then there could just be a single build script, which is better than having two probably. As I said on #7 the benefit of using Make is that it handles dependencies better than FAKE (which doesn't avoid recompilation or patterns like .el -> .elc unless I'm mistaken), but if that isn't needed and the Makefile is just a glorified shell script then it seems reasonable to use FAKE.

@rneatherway
Copy link
Member

(But @kjnilsson would know best for this repo)

@panesofglass
Copy link
Contributor Author

I won't remove the Makefile; I will just add a build.sh.

@panesofglass
Copy link
Contributor Author

Honestly, bash and powershell are probably sufficient.

@panesofglass
Copy link
Contributor Author

FWIW, I'm happy to remove the PowerShell attempt. I thought that might be simple, but I'm no PowerShell expert. Perhaps @ctaggart or some other PS whiz could help if there's interest.

@panesofglass
Copy link
Contributor Author

Please note, while I added install.sh, I have not tested it on *nix. I tried it in Git Bash, and it fails b/c of WebClient.DownloadFile, so it may not work on *nix.

@rojepp
Copy link

rojepp commented May 26, 2015

In sublime, I let paket handle the downloading of FSAC, I thought it was neat. :)
fsprojects/zarchive-sublime-fsharp-package#5
Still have to unzip it though.

kjnilsson added a commit that referenced this pull request May 26, 2015
@kjnilsson kjnilsson merged commit 5c977a1 into fsharp:master May 26, 2015
@panesofglass panesofglass deleted the windows-build branch May 26, 2015 20:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants