Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for arcanist config file extensions #1123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS.rst
Original file line number Diff line number Diff line change
Expand Up @@ -144,3 +144,4 @@ Contributors
- Skyler Grey <[email protected]>
- Emil Velikov <[email protected]>
- Linnea Gräf <[email protected]>
- Yongmin Hong <[email protected]>
2 changes: 2 additions & 0 deletions changelog.d/added/added-arcanist.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Added `.arcconfig`, `.arclint`, `.arcunit` (all uncommentable) as recognized
file types for comments. (#1123)
4 changes: 4 additions & 0 deletions src/reuse/comment.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
# SPDX-FileCopyrightText: 2023 Shun Sakai <[email protected]>
# SPDX-FileCopyrightText: 2024 Rivos Inc.
# SPDX-FileCopyrightText: 2024 Anthony Loiseau <[email protected]>
# SPDX-FileCopyrightText: 2024 Yongmin Hong <[email protected]>
#
# SPDX-License-Identifier: GPL-3.0-or-later

Expand Down Expand Up @@ -838,6 +839,9 @@ class XQueryCommentStyle(CommentStyle):
}

FILENAME_COMMENT_STYLE_MAP = {
".arcconfig": UncommentableCommentStyle, # is a JSON file
".arclint": UncommentableCommentStyle, # is a JSON file
".arcunit": UncommentableCommentStyle, # is a JSON file
".bashrc": PythonCommentStyle,
".bazelignore": PythonCommentStyle,
".bazelrc": PythonCommentStyle,
Expand Down