New bucket #84
Open
New bucket #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavroman
reviewed
Dec 26, 2020
| default: | ||
| console.log(`Uncaught backend http-status: ${response.status}`); | ||
| } | ||
| let products = JSON.parse(localStorage.getItem('cart')); |
gavroman
reviewed
Dec 26, 2020
src/model/bucketModel.js
Outdated
| } | ||
| let products = JSON.parse(localStorage.getItem('cart')); | ||
| const total = products.reduce((a, b) => a + b.food_price * b.count, 0); | ||
| this.eventBus.call('SHOW_CART', { total: total, products: products, addresses: {} }); |
There was a problem hiding this comment.
{ total, products, addresses: {} }
gavroman
reviewed
Dec 26, 2020
src/model/bucketModel.js
Outdated
| console.log(`Uncaught backend http-status: ${response.status}`); | ||
| } | ||
| let products = JSON.parse(localStorage.getItem('cart')); | ||
| products = products.filter((product) => { return product.id != productId; }); |
There was a problem hiding this comment.
(product) => product.id !== productId
- давай уберем
products = products.filterи сделаем
localStorage.setItem('cart', JSON.stringify(products.filter(.............)));
gavroman
reviewed
Dec 26, 2020
src/model/storeModel.js
Outdated
| const response = await addProductToBucket(productId); | ||
| addToCart (product) { | ||
| product.count = 1; | ||
| let productsJSON = localStorage.getItem('cart'); |
gavroman
reviewed
Dec 26, 2020
src/model/storeModel.js
Outdated
| if (productsJSON === null) { | ||
| let products = []; | ||
| products.push(product); | ||
| localStorage.setItem('cart', JSON.stringify(products)); |
There was a problem hiding this comment.
JSON.stringify([product]) и без лишних действий тогда
gavroman
reviewed
Dec 26, 2020
| console.log(`Uncaught backend http-status: ${response.status}`); | ||
| let products = JSON.parse(productsJSON); | ||
| if(products.some(p => p.id === product.id)){ | ||
| return |
There was a problem hiding this comment.
const + по линтеру траблы
gavroman
reviewed
Dec 26, 2020
src/model/storeModel.js
Outdated
| } | ||
|
|
||
| products.push(product); | ||
| localStorage.setItem('cart', JSON.stringify(products)); |
There was a problem hiding this comment.
вместо того, что бы пушить в массив, можно сделать так JSON.stringify([...products, product])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.