This repository was archived by the owner on Feb 19, 2020. It is now read-only.
Fix hostname matching with user-provided certs #501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-provided certs would cause
XMLStream.start_tls
to fail because theSSLContext
object hadcheck_hostname
set, but noserver_hostname
was provided toSSLContext.wrap_socket
. This would cause the connetion to fail and SleekXMPP to produce the following error message:Fix this by passing the hostname, which fortunately had been saved in
XMLStream._expected_server_name
.