Fix missing comparison for equal versions #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
part:tests
There was a problem hiding this comment.
Pull Request Overview
This PR fixes two issues in the Mike version comparator: it corrects regex patterns to properly escape dots and adds handling for equal versions.
- Updated Mike version regexes to escape
.so non-semver strings likev0x1e1are no longer accepted. - Introduced a direct equality check in
compare_mike_versionfor non-semver versions. - Added test cases for equal and malformed-version comparisons and updated release notes.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/mkdocs/test_mike.py | Added tests for equal non-semver versions and malformed semver |
| src/frequenz/repo/config/mkdocs/mike.py | Escaped . in regexes and added version equality check |
| RELEASE_NOTES.md | Documented both bug fixes |
Comments suppressed due to low confidence (1)
tests/mkdocs/test_mike.py:268
- Missing test for semver-equal versions. Add a case like ("v1.0", "v1.0", 0) to verify that equal semver inputs return 0.
("v1.0", "v1.0", 0)
Marenz
previously approved these changes
Jun 16, 2025
Signed-off-by: Leandro Lucarella <[email protected]>
This means that a version like v0x1e1 were accepted as valid semver versions. Now this version is not considered a semver version anymore. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
|
Rebased to fix conflicts and added a commit to prepare the release notes for the release. |
Marenz
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mikeversions when versions were equal... This means that a version like v0x1e1 were accepted as valid semver versions. Now this version is not considered a semver version anymore.