-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new split workflow Ubuntu 24.04 in workflows #369
Conversation
a8726fa
to
372cb9f
Compare
I just added a couple of notes to let users know they should add other unstable dependencies to the exclusions and check the dependabot file if they made changes. |
Damn, the CI is failing because we need to add new docker files for the new ubuntu version for cross-arch tests. But we are getting rid of cross-arch tests soon as now there are native arm runners available, so I will just go ahead and do that jump, I don´t want to keep maintaining this damn qemu boilerplate. |
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
These new workflows also start using a new reusable `gh-action-nox`, native arm runners and Ubuntu 24.04, as Ubuntu 20.04 will be removed from GitHub runners by April's 1st. Python 3.12 is also added to the test matrix. https://github.blog/changelog/2025-01-15-github-actions-ubuntu-20-runner-image-brownout-dates-and-other-breaking-changes/ The PR action is more lightweight, and only tests with one matrix (the most widely used), so PRs can be tested more quickly. The push workflow does a more intense testing with all matrix combinations. This also runs for the merge queue, so before PRs are actually merged the tests will run for the complete matrix. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
af11d80
to
d5467d0
Compare
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
OK, I finally bitten the bullet and repurposed the PR to introduce the new split workflow we are using in other repos, like the SDK, as it has many many advantages. This makes it a bit more heavy as an upgrade, but it will make upgrading easier (not only because of the dependabot changes, but also because these new workflows also use a few new reusable actions, so we can change workflows by changing the actions without requiring any templates updates). I tested this in a fork of mine and seems to be working correctly, due to the urgency of the Ubuntu upgrade, I will force-merge this and make the release (and 🙏). |
These new workflows also start using a new reusable
gh-action-nox
, native arm runners and Ubuntu 24.04, as Ubuntu 20.04 will be removed from GitHub runners by April's 1st. Python 3.12 is also added to the test matrix.The PR action is more lightweight, and only tests with one matrix (the most widely used), so PRs can be tested more quickly.
The push workflow does a more intense testing with all matrix combinations. This also runs for the merge queue, so before PRs are actually merged the tests will run for the complete matrix.
Fixes #342, #341. Improves #59.