Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new split workflow Ubuntu 24.04 in workflows #369

Merged
merged 10 commits into from
Mar 29, 2025

Conversation

llucax
Copy link
Contributor

@llucax llucax commented Mar 28, 2025

These new workflows also start using a new reusable gh-action-nox, native arm runners and Ubuntu 24.04, as Ubuntu 20.04 will be removed from GitHub runners by April's 1st. Python 3.12 is also added to the test matrix.

The PR action is more lightweight, and only tests with one matrix (the most widely used), so PRs can be tested more quickly.

The push workflow does a more intense testing with all matrix combinations. This also runs for the merge queue, so before PRs are actually merged the tests will run for the complete matrix.

Fixes #342, #341. Improves #59.

@llucax llucax requested a review from a team as a code owner March 28, 2025 15:56
@llucax llucax requested a review from shsms March 28, 2025 15:56
@github-actions github-actions bot added the part:template Affects the cookiecutter template files label Mar 28, 2025
@llucax llucax added the part:ci Affects the GitHub workflow and other parts for running CI label Mar 28, 2025
@llucax llucax self-assigned this Mar 28, 2025
@llucax llucax added this to the v0.13.0 milestone Mar 28, 2025
@llucax llucax force-pushed the ubuntu-24.04 branch 2 times, most recently from a8726fa to 372cb9f Compare March 28, 2025 16:12
@llucax
Copy link
Contributor Author

llucax commented Mar 28, 2025

I just added a couple of notes to let users know they should add other unstable dependencies to the exclusions and check the dependabot file if they made changes.

@llucax
Copy link
Contributor Author

llucax commented Mar 28, 2025

Damn, the CI is failing because we need to add new docker files for the new ubuntu version for cross-arch tests. But we are getting rid of cross-arch tests soon as now there are native arm runners available, so I will just go ahead and do that jump, I don´t want to keep maintaining this damn qemu boilerplate.

llucax added 7 commits March 29, 2025 17:58
Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
These new workflows also start using a new reusable `gh-action-nox`,
native arm runners and Ubuntu 24.04, as Ubuntu 20.04 will be removed
from GitHub runners by April's 1st. Python 3.12 is also added to the
test matrix.

https://github.blog/changelog/2025-01-15-github-actions-ubuntu-20-runner-image-brownout-dates-and-other-breaking-changes/

The PR action is more lightweight, and only tests with one matrix (the
most widely used), so PRs can be tested more quickly.

The push workflow does a more intense testing with all matrix
combinations. This also runs for the merge queue, so before PRs are
actually merged the tests will run for the complete matrix.

Signed-off-by: Leandro Lucarella <[email protected]>
@llucax llucax force-pushed the ubuntu-24.04 branch 3 times, most recently from af11d80 to d5467d0 Compare March 29, 2025 20:24
@llucax llucax changed the title Use Ubuntu 24.04 in workflows Use new split workflow Ubuntu 24.04 in workflows Mar 29, 2025
@llucax
Copy link
Contributor Author

llucax commented Mar 29, 2025

OK, I finally bitten the bullet and repurposed the PR to introduce the new split workflow we are using in other repos, like the SDK, as it has many many advantages. This makes it a bit more heavy as an upgrade, but it will make upgrading easier (not only because of the dependabot changes, but also because these new workflows also use a few new reusable actions, so we can change workflows by changing the actions without requiring any templates updates).

I tested this in a fork of mine and seems to be working correctly, due to the urgency of the Ubuntu upgrade, I will force-merge this and make the release (and 🙏).

@llucax llucax linked an issue Mar 29, 2025 that may be closed by this pull request
@llucax llucax merged commit 4233bc8 into frequenz-floss:v0.x.x Mar 29, 2025
5 checks passed
@llucax llucax deleted the ubuntu-24.04 branch March 29, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part:ci Affects the GitHub workflow and other parts for running CI part:template Affects the cookiecutter template files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ubuntu 20.04 is going down in GitHub Actions Use GitHub Actions native arm64 runners
2 participants