Make AddComponentBounds more consistent with other RPCs
#270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `AddComponentBoundsRequest.validity_duration` field was replaced by `AddComponentBoundsRequest.request_lifetime` to match the fields in `SetComponentPowerActiveRequest` and `SetComponentPowerReactiveRequest`. The default value was also changed from 5 to 60 seconds. Signed-off-by: Leandro Lucarella <[email protected]>
The `AddComponentBoundsResponse.ts` field was renamed to `AddComponentBoundsResponse.valid_until` for extra clarity and also to match the fields in `SetComponentPowerActiveResponse` and `SetComponentPowerReactiveResponse`. Signed-off-by: Leandro Lucarella <[email protected]>
llucax
requested review from
tiyash-basu-frequenz
and removed request for
a team
github-actions
bot
added
part:docs
|
I updated the defaults to match the ones in |
llucax
added
scope:breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AddComponentBoundsRequest.validity_durationfield was replaced byAddComponentBoundsRequest.request_lifetimeto match the fields inSetComponentPowerActiveRequestandSetComponentPowerReactiveRequest. The default value was also changed from 5 to 60 seconds.The
AddComponentBoundsResponse.tsfield was renamed toAddComponentBoundsResponse.valid_untilfor extra clarity and also to match the fields inSetComponentPowerActiveResponseandSetComponentPowerReactiveResponse.Fixes #269.