Add filters ids and type #210
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Marenz
commented
Oct 24, 2024
Marenz
commented
- Add filter support for ids and type
github-actions
bot
added
part:docs
Signed-off-by: Mathias L. Baumann <[email protected]>
llucax
reviewed
Oct 30, 2024
Comment on lines
+316
to
+319
| // - To retrieve dispatches with ids containing 123 (e.g.: [5123, 1234, 1235, 123]): | ||
| // filter { ids: [123] } | ||
| // - To retrieve dispatches with ids containing 1 and 5 (e.g.: [5, 1, 15, 51]): | ||
| // filter { ids: [1, 5] } |
There was a problem hiding this comment.
Shouldn't this say "or" instead of "and"? If it is "and", I would expect 5 and 1 not to match.
There was a problem hiding this comment.
true, though this will be changed again once UX made up their mind what they even want
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.