Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current setup for the
check
script is a bit difficult and verbose. For example, having to count the errors manually is a PITA, introducing warnings would make the issue even worse.Thus, I would like to
Validator
, instead of the functiondo_checks
, so we still could invoke it multiple times with differentsrcdir
and get different counters[community] bgp.peer1.ipv4 invalid address: 123.456.789.0
or[community1,community2] networks.ipv4 overlap: 0.0.0.0/0 (community1), 10.0.0.0/24 (community2)
. I'm not totally sure on the details, but I find the current free text hard to correlate to the YAML.This pull request is currently there to discuss these ideas. I'd like to hear comments. :)