check domain for trailing dot

having a trailing dot in domainname is a common Copy&Paste error but generates wrong config files Signed-off-by: Blackyfff <[email protected]>
freifunk · Jan 25, 2021 · 39c74d5 · 39c74d5
1 parent 898eb44
commit 39c74d5
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/check b/check
@@ -298,6 +298,9 @@ def do_checks(srcdir):
             errcnt += check_rdns(data)
             for domain in data.get('domains', []):
                 errcnt += check_dupe("Domain", domain.upper(), domains, community)
+                if domain.endswith( '.' ):
+                    errcnt += 1
+                    error("Domain ends with .: %s" % (domain))
                 try:
                     domain.encode("ascii").decode("idna")
                 except (UnicodeEncodeError, UnicodeError):