Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for dangling private groups #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rcritten
Copy link
Collaborator

@rcritten rcritten commented Jun 5, 2020

Users and private groups are supposed to be linked together by
the mepmanaged plugin but we've seen occasions where this linkage
is broken. Look for private groups that have no associated users.

https://pagure.io/freeipa/issue/1749

Users and private groups are supposed to be linked together by
the mepmanaged plugin but we've seen occasions where this linkage
is broken. Look for private groups that have no associated users.

https://pagure.io/freeipa/issue/1749
@fcami
Copy link
Collaborator

fcami commented Jun 10, 2020

LGTM.

@fcami
Copy link
Collaborator

fcami commented Jun 10, 2020

As a summary of the existing discussion: the check seems right, but can be long running. There is also no reason to launch that long-running test on all replica where healthcheck runs.
It would better to have a "heavy" category of checks that are only run on-demand (and on a hidden replica, when it makes sense to run these only on a single one) before merging this.

@fcami fcami added the wip Work in progress - do not merge even if CI passes label Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip Work in progress - do not merge even if CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants