ahci.4: make HARDWARE section more conformant #1662
Conversation
kenrap
force-pushed
the
ahci-hardware-conform
branch
from
ed37c14 to
d6094f1
Compare
|
This is kind of a hard one, and it's pretty fine the way it is. I'm not really sure how to improve it, rather. A good choice would be like, whatever starts with "The currently supported ATA/SATA controller chips are:" below it, because we have no idea. Many drivers need just the first sentence fixed so it's clear in the HW Relnotes what's going on there. Some others:
|
It seems that uipaq(4) already had all the items from the release notes in its HARDWARE section. But in the release notes, it's not properly formatted with asterisk bullets. |
|
Oh I missed it because it's sorted wrong. Edit: Hmmm. That might actually be a better way to sort it? |
|
I'm going to make a puc(4) PR soon that adds a HARDWARE section for it. |
| .It Type: Ta Code: | ||
| .It Mass Storage Ta PCI Class 0x01 | ||
| .It SATA Ta Subclass 0x06 | ||
| .It AHCI Ta Programming Interface 0x01 | ||
| .It Legacy-PATA + AHCI-SATA via ata(4) Ta Programming Interface 0x01 |
There was a problem hiding this comment.
This is not a list of compatible controllers. Those are requisites that must be met same time for the driver to attach.
There was a problem hiding this comment.
Yeah, as I said above I don't think we can really improve this one from what is currently in the tree.
|
Should I close this or would there be value into keeping this open? |
@concussious
Also, I'm not sure how to conform the next paragraph about nvme(4).