Skip to content

termcap: add entry for Alacritty #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

svmhdvn
Copy link
Contributor

@svmhdvn svmhdvn commented Apr 4, 2025

Converted using tic -C <upstream alacritty.info file> and tested locally with $HOME/.termcap. I'm not very familiar with termcap files, but this seems to work for me, so please do additional testing if needed.

@svmhdvn svmhdvn force-pushed the push-nznvkpypnttm branch from 829ba0e to 3b6aa6a Compare April 4, 2025 14:05
@concussious
Copy link
Contributor

concussious commented Apr 4, 2025

Hi! Thanks for sending a patch. What problem does this solve? I've been using Alacrity on FreeBSD for several years, and haven't noticed anything.

@svmhdvn
Copy link
Contributor Author

svmhdvn commented Apr 4, 2025

Hi! Thanks for sending a patch. What problem does this solve? I've been using Alacrity on FreeBSD for several years, and haven't noticed anything.

This may be because your configuration of alacritty is reporting a TERM other than "alacritty", e.g. "xterm-256".

Out of the box on other platforms, alacritty reports TERM=alacritty. This requires an updated terminfo/termcap database that contains an entry for alacritty. When I try to ssh into a FreeBSD machine using a default configuration of alacritty on my macos system, it reports this in my motd(5):

No entry for terminal type "alacritty";
using dumb terminal settings.

@concussious
Copy link
Contributor

Out of the box on other platforms, alacritty reports TERM=alacritty. This requires an updated terminfo/termcap database that
Out of the box on other platforms, alacritty reports TERM=alacritty. This requires an updated terminfo/termcap database that contains an entry for alacritty. When I try to ssh into a FreeBSD machine using a default configuration of alacritty on my macos system, it reports this in my motd(5):

No entry for terminal type "alacritty";
using dumb terminal settings.

Makes sense, thanks! You should put that (or something more terse) in the commit message.

@svmhdvn svmhdvn force-pushed the push-nznvkpypnttm branch from 3b6aa6a to b6b530e Compare April 4, 2025 19:59
@svmhdvn
Copy link
Contributor Author

svmhdvn commented Apr 4, 2025

Thanks! Added more info to the commit message.

@svmhdvn svmhdvn force-pushed the push-nznvkpypnttm branch from b6b530e to 55a04f7 Compare April 8, 2025 15:36
Out of the box on other platforms, alacritty reports `TERM=alacritty`. This requires an updated terminfo/termcap database that contains an entry for `alacritty`. Prior to this change, when you ssh into a FreeBSD machine using a default configuration of alacritty on a client system, it reports this in `motd(5)`:

```
No entry for terminal type "alacritty";
using dumb terminal settings.
```

This change adds a termcap entry for alacritty, converted from the upstream-provided `alacritty.info` using `tic -C`.

Signed-off-by: Siva Mahadevan <[email protected]>
@svmhdvn svmhdvn force-pushed the push-nznvkpypnttm branch from 55a04f7 to acfae70 Compare April 12, 2025 13:13
@concussious
Copy link
Contributor

Please do not push rebases. Once someone has approved it, we have to review it again and it is very difficult to see what has changed.

@svmhdvn
Copy link
Contributor Author

svmhdvn commented Apr 12, 2025 via email

@bsdimp
Copy link
Member

bsdimp commented Apr 12, 2025

Actually, rebase pushes are fine... though we prefer that you only push a rebase when you had to do something to fix a conflict. If it's clear the rebase is the same as before, though it's not a big deal. When you do push a rebase to fix a conflict, it's good to add a note explaining the fix...

We're happy you are contributing and can be flexible so kong as that flexibility doesn't cost us much time.

@concussious
Copy link
Contributor

Yes, I hope I didn't sound mean or grumpy, just trying to give helpful advice; I definitely wasn't mad/ didn't want to give any incorrect impression.

@svmhdvn
Copy link
Contributor Author

svmhdvn commented Apr 12, 2025

Makes sense! Github's interface makes an unnecessary notice upon a rebase when the actual patch contents don't effectively change, so I do prefer the older send-email patch based workflow (or the similar bugzilla workflow) for this reason. Patches stay static until there's a necessity for rebase.

I just had some bad automation in my local scripts that unnecessarily pushed to all my remotes too many times. I'll fix that locally and only push if the patch content changes.

@bapt
Copy link
Member

bapt commented Apr 16, 2025

merged thanks

@bapt bapt closed this Apr 16, 2025
@emaste emaste added the merged Closed commit that's been merged label Apr 16, 2025
@svmhdvn svmhdvn deleted the push-nznvkpypnttm branch June 20, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged Closed commit that's been merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants