-
Notifications
You must be signed in to change notification settings - Fork 3.1k
termcap: add entry for Alacritty #1638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
829ba0e
to
3b6aa6a
Compare
Hi! Thanks for sending a patch. What problem does this solve? I've been using Alacrity on FreeBSD for several years, and haven't noticed anything. |
This may be because your configuration of alacritty is reporting a TERM other than "alacritty", e.g. "xterm-256". Out of the box on other platforms, alacritty reports
|
Makes sense, thanks! You should put that (or something more terse) in the commit message. |
3b6aa6a
to
b6b530e
Compare
Thanks! Added more info to the commit message. |
b6b530e
to
55a04f7
Compare
Out of the box on other platforms, alacritty reports `TERM=alacritty`. This requires an updated terminfo/termcap database that contains an entry for `alacritty`. Prior to this change, when you ssh into a FreeBSD machine using a default configuration of alacritty on a client system, it reports this in `motd(5)`: ``` No entry for terminal type "alacritty"; using dumb terminal settings. ``` This change adds a termcap entry for alacritty, converted from the upstream-provided `alacritty.info` using `tic -C`. Signed-off-by: Siva Mahadevan <[email protected]>
55a04f7
to
acfae70
Compare
Please do not push rebases. Once someone has approved it, we have to review it again and it is very difficult to see what has changed. |
On April 12, 2025 6:16:58 p.m. UTC, Alexander Ziaee ***@***.***> wrote:
concussious left a comment (freebsd/freebsd-src#1638)
Please do not push rebases. Once someone has approved it, we have to review it again and it is very difficult to see what has changed.
--
Reply to this email directly or view it on GitHub:
#1638 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
Got it thanks! Won't push in the future.
|
Actually, rebase pushes are fine... though we prefer that you only push a rebase when you had to do something to fix a conflict. If it's clear the rebase is the same as before, though it's not a big deal. When you do push a rebase to fix a conflict, it's good to add a note explaining the fix... We're happy you are contributing and can be flexible so kong as that flexibility doesn't cost us much time. |
Yes, I hope I didn't sound mean or grumpy, just trying to give helpful advice; I definitely wasn't mad/ didn't want to give any incorrect impression. |
Makes sense! Github's interface makes an unnecessary notice upon a rebase when the actual patch contents don't effectively change, so I do prefer the older send-email patch based workflow (or the similar bugzilla workflow) for this reason. Patches stay static until there's a necessity for rebase. I just had some bad automation in my local scripts that unnecessarily pushed to all my remotes too many times. I'll fix that locally and only push if the patch content changes. |
merged thanks |
Converted using
tic -C <upstream alacritty.info file>
and tested locally with$HOME/.termcap
. I'm not very familiar with termcap files, but this seems to work for me, so please do additional testing if needed.