Replace sprockets-sass with dartsass-sprockets #2649
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modernizes the Sass compilation pipeline by migrating from the deprecated
sprockets-sassgem todartsass-sprockets. Closes #2214 and #2450.After merging, the way should be clear to upgrade various other gems previously blocked by Sass.
Highlights
sprocketsto v4sprockets-sasswithdartsass-sprocketsin the build pipeline.scss.erbfiles to the Thor task.dart-sassdoesn't handle ERB preprocessing automatically, so this step is now explicit in the build process@importstatements in favor of@useTesting Notes
There should be no user-facing impact. I did my utmost to confirm this through smoke tests, env comparisons, unit tests, etc. Verifying the quality of a production build on my li'l dev machine is possibly beyond my understanding, but will gladly take any advice.