-
-
Notifications
You must be signed in to change notification settings - Fork 379
chore: change files structure #1286
chore: change files structure #1286
Conversation
03f9ae3
to
f442462
Compare
f442462
to
00ebad9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way ScrollToTop is currently structured doesn't make it a hook based on the definition set by the official react docs
https://react.dev/learn/reusing-logic-with-custom-hooks
right now it is just a custom component not a hook and should stay in the components folders
actually this hook (or component) is not used anywhere in the code, as far as i can see |
Looking through the history is looks like the ScrollToTop was used in the early versions of the app.tsx file but later removed. As for that others changes, I don't see any reason to remove the App.tsx file and move everything into the index.tsx file. |
Currently there is most of app logic at
Main.tsx file, I think I will rename it to be App.tsx, will it be good?
…On Thu, Jan 23, 2025, 08:51 Jessica Wilkins ***@***.***> wrote:
Looking through the history is looks like the ScrollToTop was used in the
early versions of the app.tsx file but later removed.
So it looks like that can be removed completely.
As for that others changes, I don't see any reason to remove the App.tsx
file and move everything into the index.tsx file.
Those changes should be reverted.
—
Reply to this email directly, view it on GitHub
<#1286 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKGMHSZ2ODK5YALA6KIM6T2MCGO3AVCNFSM6AAAAABVHCAW4GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBYHE4TKMRWGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
The current As for this PR, we should do the following
once things have been properly refactored in separate issues to make things more maintainable, then the renaming will make sense |
I agree with you.
can i move the QuizTemplate out of `components` folder? (since it is
different from Button or Modal reusable componments)
…On Thu, Jan 23, 2025 at 10:12 AM Jessica Wilkins ***@***.***> wrote:
The current QuizTemplate has WAY to much going on and has become bloated
over the past few years.
That is a whole other separate issue.
As for this PR, we should do the following
- add back in the App.tsx to the way it was.
- revert the changes for the index.tsx file
- remove the ScrollToTop since it is not being used
- revert the changes for the rename of the QuizTemplate
once things have been properly refactored in separate issues to make
things more maintainable, then the renaming will make sense
—
Reply to this email directly, view it on GitHub
<#1286 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKGMHW2RNG7PMVD35U4NPT2MCP65AVCNFSM6AAAAABVHCAW4GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBZGEYTQMZRGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
sure |
did the requested changes:
|
is there some more things to be fixed? |
Summary of changes
the purpose of this change is to make the code more readable and convenient for developer...
Checklist
closes #1285