Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify default flow direction to bidirectional #37

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

leowu0407
Copy link
Contributor

@leowu0407 leowu0407 commented Jan 15, 2025

This PR is to solve problem 4 of issue #627.
According to TS 24.501 6.2.5.1.1.2, I modify the flow direction of the default PCC rule from downlink to bidirectional.
image

@leowu0407 leowu0407 force-pushed the fix/default-flow-direction branch from cc14a74 to a3c95cd Compare January 15, 2025 16:18
@Alonza0314
Copy link

LGTM!

@andy89923
Copy link
Contributor

Hi @leowu0407,

Please provide the spec number and the section about why you have these changes.
Thanks!

@leowu0407
Copy link
Contributor Author

Hi @leowu0407,

Please provide the spec number and the section about why you have these changes. Thanks!

Hi @andy89923 ,
I have updated the PR description.
Thanks for your reminder!

@Alonza0314
Copy link

@leowu0407
Hi, please also add the issue mention!

@ianchen0119
Copy link
Contributor

Hi @leowu0407 @Alonza0314
Please remember to cherry-pick the commit into next branch.

Thanks.

@ianchen0119 ianchen0119 merged commit d602870 into free5gc:main Jan 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants