Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSL Regression #16

Merged
merged 10 commits into from
Aug 11, 2024
Merged

Fix SSL Regression #16

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8993fcb
cleanup
kingy444 Jun 14, 2024
e61e38c
use query string for set_zone
kingy444 Jun 14, 2024
70f1d1c
dont remove spaces in logging
kingy444 Jun 14, 2024
b619529
Add messaging on why query params are required
kingy444 Jul 3, 2024
ad3c487
Fix line too long
kingy444 Jul 3, 2024
37efc61
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 3, 2024
5430d1b
Merge branch 'fredrike:master' into master
kingy444 Aug 11, 2024
fd80b23
fix ssl regression
kingy444 Aug 11, 2024
29c3adc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 11, 2024
a170971
Merge branch 'master' into master
fredrike Aug 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions pydaikin/daikin_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class Appliance(DaikinPowerMixin): # pylint: disable=too-many-public-methods
"""Daikin main appliance class."""

base_url: str
headers: Optional[dict] = None
headers: dict = {}
session: Optional[ClientSession]
ssl_context: Optional[SSLContext] = None

Expand Down Expand Up @@ -135,19 +135,17 @@ async def _get_resource(self, path: str, params: Optional[dict] = None):
if params is None:
params = {}

headers = self.headers
if headers is None:
headers = {}

_LOGGER.debug("Calling: %s/%s %s [%s]", self.base_url, path, params, headers)
_LOGGER.debug(
"Calling: %s/%s %s [%s]", self.base_url, path, params, self.headers
)

# cannot manage session on outer async with or this will close the session
# passed to pydaikin (homeassistant for instance)
async with self.request_semaphore:
async with self.session.get(
f'{self.base_url}/{path}',
params=params,
headers=headers,
headers=self.headers,
ssl_context=self.ssl_context,
) as response:
if response.status == 403:
Expand Down
Loading