improve getJsonBody error output #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-martin
requested review from
a team,
stackptr,
pbrisbin and
mjgpy3
and removed request for
a team and
stackptr
chris-martin
force-pushed
the
chris/json
branch
3 times, most recently
from
fe21438 to
c1f6970
Compare
pbrisbin
approved these changes
Sep 19, 2024
chris-martin
force-pushed
the
chris/json
branch
from
c1f6970 to
872ce2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getJsonBodynow just passes through to yesod-test, andgetCsvBodyis a copy of what that does.I'm being lazy and skipping over the CSV content type check right now because I don't immediately know what the MIME type is or if we always set it correctly in our app.