Remove redis-cache volume

[sdfateh]

Details of the Change:

This pull request addresses an issue where the assets.json file, now stored in Redis by Frappe, persists across new image builds due to the Redis cache volume being persistent. This prevents updates to assets.json from being reflected after a new build.

The proposed change removes the persistent volume for redis-cache, ensuring that the cache, including assets.json, is cleared during each new image deployment.

Problem Solved:

By removing the persistent Redis volume, we prevent outdated assets.json data from being retained, ensuring the application always works with the latest assets after a build. This eliminates the need for manual intervention or additional automation to clear the cache.

Retaining the old assets.json file will cause the websites to miss certain assets:

Why is This Necessary?

Without this change, developers or pipelines must manually clear the assets.json value from Redis or automate the process using additional scripts or hooks. Removing the persistent volume simplifies the process and avoids potential misconfigurations.

This PR was inspired by @ankush's comment on the issue frappe/frappe#29901 , as he correctly pointed out that there is no need to persist in this volume.

[gparent]

I hope this comment isn't too spammy - I just wanted to thank you for trying to improve on this and also to the others who posted solutions. I think you'll save many people a lot of frustration.

[ankush]

Change looks fine in principle.

I'd let someone with better knowledge of frappe_docker merge it though.

[Ph0en1XXX]

Hi! After removing volumes and docker-compose up -d I got a new "404 Not Found". Could deleting the Redis cache volume have affected this error?

[sdfateh]

@Ph0en1XXX

How did you handle volume removal? It seems like you deleted the sites volume

[Ph0en1XXX]

I did docker-compose down -v
When reinstalledfull images using the script for lms, but with my own image.

python3 ./easy-install.py deploy
--project=learning_prod_setup
--email=your_email.example.com
--image=ghcr.io/frappe/lms
--version=stable
--app=lms
--sitename subdomain.domain.tld

[Ph0en1XXX]

I did docker-compose down -v When reinstalledfull images using the script for lms, but with my own image.

python3 ./easy-install.py deploy --project=learning_prod_setup --email=your_email.example.com --image=ghcr.io/frappe/lms --version=stable --app=lms --sitename subdomain.domain.tld

Fixed with just launching default script image then changed to my own (learning_prod_setup-compose.yml)