feat: Add integration to shiprocket, delhivery, aramex, envia, shippo #50
Conversation
There was a problem hiding this comment.
Regarding the Shipping Provider doctype: when you want to contribute new features, it's a bad idea to change the architecture at the same time. Please stick to the existing architecture. I'm sure there are pros and cons to both. But I think there is not a good reason to change or use two different architectures at the same time.
|
Hi @barredterra , The existing way is creating new single doctypes for each of the providers. We will end up creating 5 new single doctypes for this. Also, when there are multiple companies on the same site, when two different companies have to use the same shipping provider with two different accounts (and so their credentials), the existing way isn't supporting it. That is limiting. We should consider moving LetmeShip and Send Cloud to the Shipping Provider in a different PR with a patch to migrate their data. What do you suggest? |
|
It is a very established practice that every integration gets its own settings doctype. (except when all use the same protocol, e.g. social login). Here, every shipping provider is different, as indicated by the many conditional fields and individual interfaces. Trying to fit them all into the same DocType isn't helpful and breaks with the existing architecture. You get one overly complex DocType instead of many simple ones. Regarding multi-company support, the individual provider settings could be a list with one entry per company. |
|
Yes, as we are also considering bringing in a few more providers, we might be heading towards one overly complex doctype. Will move towards a non-single doctype for each of the providers. Please suggest what will be the right place to set up a preferred provider. If this isn't set, on the fetch price, the call is made to all the configured providers. |
ravibharathi656
force-pushed
the
shipping_integration
branch
from
6cf31ab to
032cd7a
Compare
* fix: phone number regex * fix: suggested change Co-authored-by: Raffael Meyer <[email protected]> --------- Co-authored-by: Marc-Constantin Enke <[email protected]> Co-authored-by: Raffael Meyer <[email protected]> (cherry picked from commit 5e3df2c) Co-authored-by: Marc <[email protected]>
ravibharathi656
force-pushed
the
shipping_integration
branch
from
032cd7a to
8bb9410
Compare
ravibharathi656
force-pushed
the
shipping_integration
branch
from
8bb9410 to
1b98ec1
Compare
ravibharathi656
force-pushed
the
shipping_integration
branch
2 times, most recently
from
aa159e2 to
ce1422c
Compare
|
@ravibharathi656 @Vigneshsekar maybe you faced the same issue. If you like, add your two cents here: frappe/erpnext#46454 |
erpnext_shipping/erpnext_shipping/doctype/shiprocket/shiprocket.json
Outdated
Show resolved
Hide resolved
|
Hello @barredterra @Vigneshsekar , I have tested the integration for all providers after refactoring. |
| elif service_provider == SHIPROCKET_PROVIDER: | ||
| shipping_label = [] | ||
| shiprocket = ShiprocketUtils(company=pickup_company) | ||
| label_url = shiprocket.generate_label(shipment_id, shipment) | ||
| if not label_url: | ||
| frappe.throw(_("Failed to generate label.")) | ||
| file_url = save_label_as_attachment(shipment=shipment, url=label_url) | ||
| shipping_label.append(file_url) | ||
| elif service_provider == ENVIA_PROVIDER: | ||
| shipping_label = [] | ||
| file_url = get_shipping_label(shipment) | ||
| if not file_url: | ||
| frappe.throw(_("Failed to generate label.")) | ||
| shipping_label.append(file_url) | ||
| elif service_provider == DELHIVERY_PROVIDER: | ||
| delhivery = DelhiveryOneUtils(company=pickup_company) | ||
| shipping_label = delhivery.get_label(shipment_id) | ||
| elif service_provider == SHIPPO_PROVIDER: | ||
| shipping_label = [] | ||
| shippo = ShippoUtils(company=pickup_company) | ||
| label_url = shippo.get_label(shipment_id, shipment) | ||
| if not label_url: | ||
| frappe.throw(_("Failed to generate label.")) | ||
| file_url = save_label_as_attachment(shipment=shipment, url=label_url) | ||
| shipping_label.append(file_url) | ||
| elif service_provider == ARAMEX_PROVIDER: | ||
| shipping_label = [] | ||
| file_url = get_shipping_label(shipment) | ||
| if not file_url: | ||
| frappe.throw(_("Failed to generate label.")) | ||
| shipping_label.append(file_url) |
There was a problem hiding this comment.
I'd expect that all of these to look and behave roughly the same. Right now, some raise an error and some don't; some save as attachment and some don't.
Also, could we pull out the "Failed to generate label" check to the end, just before the return statement, so it's the same for all providers?
ravibharathi656
force-pushed
the
shipping_integration
branch
from
bb05d16 to
5ffcb32
Compare
|
@ravibharathi656 did you address all previous review comments / is this ready for a final review and merge? |
ravibharathi656
force-pushed
the
shipping_integration
branch
from
5ffcb32 to
8bbff72
Compare
Hi, @barredterra the current PR has a lot of merge commits. Would you prefer I open a clean new PR with all previous review comments addressed, or can I continue using this PR? Thanks for your patience. |
|
@ravibharathi656 either way is fine. |
Hi @barredterra, Thanks again for your patience |
|
Closing this PR to maintain a clean commit, I will make the required changes in this PR: #72 Thank you. |
As a part of this PR, I am introducing a new doctype called Shipping Provider to refactor the existing design and introducing the following integration.
The existing ones such as letmeship, sendcloud is not affected by this refactoring.
This PR also changes how the shipping providers are configured. As ERPNext can have multiple companies in it, we need to configure multiple shipping accounts of the same shipping provider.