Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(physical-restore): Optimize table validations and repair #174

Merged
merged 5 commits into from
Mar 5, 2025

Conversation

tanmoysrt
Copy link
Member

@tanmoysrt tanmoysrt commented Mar 5, 2025

  • refactor(physical-restore): Repair innodb tables with fulltext index
  • refactor(physical-restore): Avoid checking all innodb tables
  • refactor(physical-restore): For myisam table, on warning do repair

No need to waste time on checking whether index is corrupted or not
Because, physical restoration will not work for FULLTEXT index.
Large tables took lot of time
The chance of corruption in innodb table itself (not index)
is very less
So, avoid check to reduce time
@tanmoysrt tanmoysrt self-assigned this Mar 5, 2025
@tanmoysrt tanmoysrt marked this pull request as ready for review March 5, 2025 12:06
@tanmoysrt tanmoysrt merged commit 1bdd9e3 into frappe:master Mar 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant