Fix togglewifi: interpolate Interface variable#5
Open
somethingwithproof wants to merge 1 commit intofrankroeder:masterfrom
Open
Fix togglewifi: interpolate Interface variable#5somethingwithproof wants to merge 1 commit intofrankroeder:masterfrom
somethingwithproof wants to merge 1 commit intofrankroeder:masterfrom
Conversation
The variable was passed as the literal string "Interface" instead of being concatenated into the shell command. Wi-Fi never actually toggled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Interfacevariable on lines 21 and 24 is inside a quoted string, so AppleScript treats it as the literal string "Interface" rather than the value of the variable ("en0"). Thenetworksetup -setairportpowercalls never actually reference the right interface.Fixed by concatenating the variable into the command string with
&.