-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for everything I've done so far on my fork #53
base: master
Are you sure you want to change the base?
Conversation
Hi Soichi. I looked over this changes. We should discuss. I am not convinced that this is the repository we want to change. |
Franco, Do you mean the changes I made to scripts/life_demo.m? Or the fact that there are now new files specific to SCA? On the fork that I am working with Brent, we've put all the SCA related stuff under /sca directory so that those *.sh scripts will be hidden. If I can't put SCA scripts here, I will need to host those SCA script elsewhere and pull this repo as a dependency - and somehow needs to maintain compatibility with specific version of life code.. I hope we can keep it together. In any case, you can reject this pull request - since we are making other changes on our fork - we can discuss weather or not to merge it upstream. |
Hi Sochi. I guess I am still considering options for merging the SCA changes into the general repository. We might need to discuss a plan to these changes. But the would be good to do in person. Franco Pestilli
|
No description provided.