Skip to content

Adds hpack generated cabal file. #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds hpack generated cabal file. #58

wants to merge 1 commit into from

Conversation

philderbeast
Copy link
Contributor

Should I check in generated cabal files?
Yes, you should. This recommendation was changed in issue #5210, please see the discussion there.

@tomjaguarpaw
Copy link
Collaborator

My personal point of view is that we should be wary of checking in generated files (the Stack advise notwithstanding) and if we do their consistency must be checked by CI. As a non-Stack user I sympathise with those who download a repo with no .cabal file in it and then wonder how to build it. Perhaps we can explain the hpack workflow somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philderbeast @tomjaguarpaw