Skip to content

Conversation

spencerjanssen
Copy link
Contributor

SQL Server doesn't support leap seconds. Resolves #56.

FYI @chrisdone

SQL Server doesn't support leap seconds
Copy link
Contributor

@chrisdone chrisdone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what’s happening with these numbers?

@spencerjanssen
Copy link
Contributor Author

We want to avoid TimeOfDay values which are greater than or equal to 23:59:60 because SQL Server doesn't allow them.

The old upper limit of 86400 seconds represents 23:59:60, our new upper limit represents 23:59:59. The Arbitrary instances add some fractional seconds to this value which is fine because the end result is still less than 23:59:60.

Similarly 1440 minutes is 23:60 which we've adjusted to 1439 or 23:59.

Clearly this is tricky and warrants some explanation in the code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing tests on ghc 9.2.7

2 participants