#470 track and expose input tick submissions #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return -1 | ||
|
|
||
| ## Get all root nodes that have submitted input | ||
| func get_input_submissions() -> Dictionary: |
Contributor
There was a problem hiding this comment.
Do we want to keep this as a dictionary, or is it OK to expose an array of nodes that have inputs?
| ## Register that a node has submitted its input for a specific tick | ||
| func register_input_submission(root_node: Node, tick: int) -> void: | ||
| if not _input_submissions.has(root_node): | ||
| _input_submissions[root_node] = tick |
Contributor
There was a problem hiding this comment.
This dictionary never removes keys. I think for many games this won't be an issue, but if a game churns through lots of individual nodes, this could be an issue. It would be a nice to put an upper bound or similar on the dictionary size somehow.
Looping through all keys checking if the nodes are still valid could be too costly. Ideally RBS nodes would clean up after themselves. Would that break anything if we removed the input submission data once an RBS is destroyed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows NetworkRollback to track and expose the latest tick for which each node with a RollbackSynchronizer has received input submissions.
Useful for scenarios where you need to ensure all input ticks are submitted before proceeding with actions that are difficult to reverse, such as character death, visual effects, or audio triggers.