-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat(vm): support compilation profile selection in getCode #12876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
subwaycookiecrunch
wants to merge
22
commits into
foundry-rs:master
Choose a base branch
from
subwaycookiecrunch:feat/vm-get-code-profile
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(vm): support compilation profile selection in getCode #12876
subwaycookiecrunch
wants to merge
22
commits into
foundry-rs:master
from
subwaycookiecrunch:feat/vm-get-code-profile
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows specifying a profile in vm.getCode via 'Contract:Profile' syntax. Also fixes a regression in Issue12817.t.sol by using vm.setSeed.
…ookiecrunch/foundry into feat/vm-get-code-profile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Users often define multiple compilation profiles in the configuration file to test contracts against different settings (e.g., different EVM versions, optimization levels). While
vm.getCodecurrently supports selecting artifacts by Solidity version, it lacks the ability to explicitly select an artifact by its profile name. This feature enables users to retrieve the bytecode for a specific profile using the syntaxvm.getCode("Contract:Profile").Solution
I updated the cheatcode logic to handle profile names in the artifact path string.
:) as a Semantic Version.I also fixed a small regression in an existing test file where
vm.seedwas being used incorrectly; it has been replaced withvm.setSeed.PR Checklist