Skip to content

fix: use ConversionError instead of unit type in receipt conversion #12824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
onbjerg merged 1 commit into from
Dec 15, 2025
+8 −3
Merged

fix: use ConversionError instead of unit type in receipt conversion #12824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions crates/primitives/src/network/receipt.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use alloy_consensus::{Receipt, TxReceipt};
use alloy_network::{AnyReceiptEnvelope, AnyTransactionReceipt, ReceiptResponse};
use alloy_primitives::{Address, B256, BlockHash, TxHash, U64};
use alloy_rpc_types::{Log, TransactionReceipt};
use alloy_rpc_types::{ConversionError, Log, TransactionReceipt};
use alloy_serde::WithOtherFields;
use derive_more::AsRef;
use op_alloy_consensus::{OpDepositReceipt, OpDepositReceiptWithBloom};
Expand Down Expand Up @@ -77,7 +77,7 @@ impl ReceiptResponse for FoundryTxReceipt {
}

impl TryFrom<AnyTransactionReceipt> for FoundryTxReceipt {
type Error = ();
type Error = ConversionError;

fn try_from(receipt: AnyTransactionReceipt) -> Result<Self, Self::Error> {
let WithOtherFields {
Expand Down Expand Up @@ -150,7 +150,12 @@ impl TryFrom<AnyTransactionReceipt> for FoundryTxReceipt {
logs_bloom: receipt_with_bloom.logs_bloom,
})
}
_ => return Err(()),
_ => {
let tx_type = r#type;
return Err(ConversionError::Custom(format!(
"Unknown transaction receipt type: 0x{tx_type:02X}"
)));
}
},
},
other,
Expand Down
Loading