refactor(anvil): replace DepositReceipt withl op-alloy's
#11640
+191
−156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ongyimeng
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya,
zerosnacks,
onbjerg and
0xrusowsky
as code owners
|
@mattsse for your review ser |
onbjerg
requested changes
Sep 15, 2025
| EIP7702(ReceiptWithBloom<T>), | ||
| #[serde(rename = "0x7E", alias = "0x7e")] | ||
| Deposit(DepositReceipt<T>), | ||
| Deposit(OpDepositReceiptWithBloom), |
There was a problem hiding this comment.
this is a type alias for ReceiptWithBloom<OpDepositReceipt<T>>
imo, in this case, we either make T the generic for the log type, or we just ditch T entirely and make the other ReceiptWithBloom<T> concrete: ReceiptWithBloom<Receipt<Log>>
There was a problem hiding this comment.
sflr just saw this, I agree. Probably leaning towards making the others concrete. I will make the changes soon
Comment on lines
+1215
to
+1216
| .iter() | ||
| .cloned() |
There was a problem hiding this comment.
Suggested change
| .iter() | |
| .cloned() | |
| .into_iter() |
we consume the receipt here, so no need to clone
onbjerg
changed the title
DepositReceipt withl op-alloy's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #11496
Solution
Builds on top of @TropicalDog17 PR to add special handling for TypedReceipt::Deposit variants to prevent runtime panics when processing L2/Optimism deposit transactions.
PR Checklist